search

gnu-octave / symbolic

A Symbolic Package for Octave using SymPy
https://octave.sourceforge.io/symbolic/
GNU General Public License v3.0
151 stars 36 forks source link

Test Array in mat_rclist_* #1213

Closed alexvong243f closed 2 years ago

alexvong243f commented 2 years ago

This PR makes the matrclist* functions Array-compatible.

We also add the make_matrix_or_array helper function as well, which fixes #1211. dbg_no_array is set to True for now to avoid failing tests in main.

cbm755 commented 2 years ago

This looks good at a quick glance.

Should we merge it to #1194 instead of main?

alexvong243f commented 2 years ago

Sure, I can merge this to https://github.com/cbm755/octsympy/tree/Array_not_Matrix instead of main (after rebasing https://github.com/cbm755/octsympy/tree/Array_not_Matrix onto main).

This should be safer than merging to main directly.

alexvong243f commented 2 years ago

Merged onto https://github.com/cbm755/octsympy/tree/Array_not_Matrix in 5385713ccf34534366de6838691359e3ecca4065