gnu-octave / symbolic

A Symbolic Package for Octave using SymPy
https://octave.sourceforge.io/symbolic/
GNU General Public License v3.0
154 stars 36 forks source link

Bernoulli failures on SymPy 1.12 #1268

Closed cbm755 closed 1 year ago

cbm755 commented 1 year ago

I thought I fixed this kind of thing... Maybe 1.12 is not < 1.12.dev?

@sym/bernoulli ......................................... FAIL    2/5   
   >> % doctest: +XFAIL_IF(pycall_sympy__ ('return Version(spver) < Version("1.12.dev")'))
    bernoulli (sym(0:6))
      expected:    (sym) [1  1/2  1/6  0  -1/30  0  1/42]  (1×7 matrix)
      got     : ans = (sym) [1  1/2  1/6  0  -1/30  0  1/42]  (1×7 matrix)
      expected failure, but test succeeded!
   >> % doctest: +XFAIL_IF(pycall_sympy__ ('return Version(spver) < Version("1.12.dev")'))
    bernoulli (sym(1))
      expected:    (sym) 1/2
      got     : ans = (sym) 1/2
      expected failure, but test succeeded!
@sym/besselh ........................................... PASS    2/2   

Observed in Fedora build. https://kojipkgs.fedoraproject.org//work/tasks/9266/103639266/build.log

cbm755 commented 1 year ago

My guess is this is what you get without pip install packaging... will try that in the Fedora package and then try to adjust this before the next release...

cbm755 commented 1 year ago

background: our implementation of Version is sloppy without packaging.