search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

ImageMagick 7 unsupported #1044

Open paulmenzel opened 3 years ago

paulmenzel commented 3 years ago

The current official ImageMagick release is 7.1.0-4. Unfortunately, it’s not detected, as version 6 is hardcoded into the CMake module:

https://github.com/gnudatalanguage/gdl/blob/9dd65f44bf387836a6f9d661a383874d545a0c47/CMakeModules/FindImageMagick.cmake#L162-L197

A porting guide exists.

It’d be great if ImageMagick 7 was supported.

paulmenzel commented 3 years ago

I forget the logs:

$ Magick++-config --version
7.1.0 Q16 HDRI
-- Looking for ImageMagick
CMake Error at CMakeLists.txt:514 (message):
  ImageMagick is required but was not found.

  Use -DMAGICKDIR=DIR to specify the ImageMagick directory.

  Use -DMAGICK=OFF to not use it.

  (suitable Debian/Ubuntu package: libmagick++-dev)

  (suitable Fedora/CentOS package: ImageMagick-c++-devel)

-- Configuring incomplete, errors occurred!
GillesDuvert commented 3 years ago

Hello @paulmenzel do you know if imageMagick provides a proper FindImageMagick.cmake? In which cas it would be a relief not to have to maintain ours.

slayoo commented 3 years ago

It is built into CMake itself: https://cmake.org/cmake/help/latest/module/FindImageMagick.html (https://github.com/gnudatalanguage/gdl/issues/417)

slayoo commented 3 years ago

New in version 3.9: Added support for ImageMagick 7.

maynardGK commented 3 years ago

I don't think GDL has been built for ver 7, there is at least one issue with the source code to acomodate it https://github.com/gnudatalanguage/gdl/issues/521 was a short stab at using ver.7; I didn't go much beyond that.