Closed alaingdl closed 12 months ago
Attention: 26 lines
in your changes are missing coverage. Please review.
Comparison is base (
f29c1fa
) 41.17% compared to head (4052329
) 41.07%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
problem only with the TIC/TOC reported in #1661
the changes in dimension.hpp
should be explained (even if apparently inocuous) (this is legacy touchy code).
the calls ofSizeT nParam = e->NParam(xxx);
in la_trired_pro
and other functions of gsl_fun
is important, even if 'nParam
' is reported unused. by the compiler. In that case, replace, e.g., nParam = e->NParam(3);
by e->NParam(3);
avoiding creating a variable.
This patch should solve #1662. It is working now on Linux and OSX. some code will be discarded ASAP. Few others details solved. I am very sorry but no test_gaussfit up to now :disappointed: , but I have a draft :smiley_cat:
When we will have more time, it would be good to fix some of the warnings triggered by the use of the -Wall flag, especially in the core code ... (see my small change in
dimension.hpp
:)