codecov[bot]
commented
11 months ago Codecov Report
Attention: 387 lines in your changes are missing coverage. Please review.
Comparison is base (
24a3deb) 41.80% compared to head (bf04c4c) 41.94%. Report is 2 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| src/gdlhelp.cpp | 42.44% | 240 Missing :warning: |
| src/saverestore.cpp | 67.13% | 117 Missing :warning: |
| src/math_fun_ac.cpp | 0.00% | 21 Missing :warning: |
| src/dinterpreter.cpp | 64.70% | 6 Missing :warning: |
| src/dpro.cpp | 75.00% | 2 Missing :warning: |
| src/widget.cpp | 0.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1681 +/- ## ========================================== + Coverage 41.80% 41.94% +0.13% ========================================== Files 356 356 Lines 95211 95616 +405 Branches 19555 19668 +113 ========================================== + Hits 39805 40102 +297 - Misses 55406 55514 +108 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Very Good news: Saves/restore of all procedures (including object procedures) is now in GDL. Tested on ATV and, more important, SSW's HESSI library of routines. Despite compression the save files are quite large, larger than their text counterpart. But they are (partially) compiled and the time gain is in favor of using them. As most of the compiled code is a bunch of zeros, there may be a way to improve the compression.
Bad news:
RESOLVE_ALLmust be improved to find all dependencies, otherwise the use of all this is a bit restricted. Note that it is difficult also with IDL to get all needed functions, objects and data within a .sav file.Next step: provide saved (.sav) along our .pro files to speedup GDL.