gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

Tentative anwsers to #1708 (call_external(/cdecl) and to #1709 (file_readlink('/proc/self')) #1713

Closed alaingdl closed 8 months ago

alaingdl commented 8 months ago

This PR should solve #1708

Keyword /CDECL in call_external([...] /cdecl) should be silently ignored on OSX & Linux. Please contribute on MSwin

It should also solve #1709 (file_readlink('/proc/self') on Linux) I add some tests dedicated to Linux & OSX, please test & contribute for MSwin & *BSD Any other ideas welcome !

codecov[bot] commented 8 months ago

Codecov Report

Attention: 126 lines in your changes are missing coverage. Please review.

Comparison is base (e027133) 41.92% compared to head (2edee2c) 41.96%. Report is 4 commits behind head on master.

:exclamation: Current head 2edee2c differs from pull request most recent head c237b29. Consider uploading reports for the commit c237b29 to get more accurate results

Files Patch % Lines
src/basic_pro_jmg.cpp 55.43% 123 Missing :warning:
src/file.cpp 57.14% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1713 +/- ## ========================================== + Coverage 41.92% 41.96% +0.03% ========================================== Files 361 361 Lines 96379 96377 -2 Branches 19817 19815 -2 ========================================== + Hits 40410 40446 +36 + Misses 55969 55931 -38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GillesDuvert commented 8 months ago

@alaingdl there seem to be 2 "cout<<" left in file.cpp (debug ) Congrats for the quick patch!

alaingdl commented 8 months ago

@alaingdl there seem to be 2 "cout<<" left in file.cpp (debug ) Congrats for the quick patch!

in fact, those two "cout <<" are outside the field of my change, but I can comment them

alaingdl commented 8 months ago

no need to test again ... since only two cout << removed ...