search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

solving #1717 #1721

Closed GillesDuvert closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b82c737) 41.96% compared to head (79cfcf1) 41.95%.

Files Patch % Lines
src/plotting.cpp 66.66% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1721 +/- ## ========================================== - Coverage 41.96% 41.95% -0.01% ========================================== Files 361 361 Lines 96381 96381 Branches 19816 19816 ========================================== - Hits 40446 40441 -5 - Misses 55935 55940 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alaingdl commented 8 months ago

totally unclear for me why the window part is not done. Seems that a link is not done at the end of the compilation. first test is done but not really related to GDL exe it-self ?!

GillesDuvert commented 8 months ago

the windows build crash on tests approx 3/4 of the time, but in fact everything is OK, one can even retrieve the installer, install on a fresh mwindows machine, run the tests and they work. So I'm inclined to blame the test-running code and forget about it.