search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

Fixes #1724: WIDGET_SLIDER with TITLE crashes when setting value #1729

Closed frankmri closed 7 months ago

frankmri commented 8 months ago

Hi, this may not be the right way to fix this, in this case just use it as a pointer to the culprit, best, Frank.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (8157c12) 42.06% compared to head (94b2bab) 42.05%.

Files Patch % Lines
src/gdlwidget.cpp 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1729 +/- ## ========================================== - Coverage 42.06% 42.05% -0.01% ========================================== Files 361 361 Lines 96391 96399 +8 Branches 19802 19805 +3 ========================================== Hits 40543 40543 - Misses 55848 55856 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GillesDuvert commented 7 months ago

Thanks @frankmri Will merge this hopefully soon now. Congrats, this was not easy... We do not have so many contributors, especially handy with wxWidgets... :smile: .. and C++ ... :smile: ... Thanks again.

frankmri commented 7 months ago

Thank you @GillesDuvert for including this! Best