search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

Allanvar, MedAbsDev + allowing compilation without Eigen3 #1741

Closed alaingdl closed 7 months ago

alaingdl commented 7 months ago

For me it is important than GDL can still be compilable when some optional dependences (X11, wxwidgets, Eigen3, HDF5, ...) are not available. I managed here the case with Eigen3 (eg. : IM/GM packages are broken on my Ubuntu 20.04 then it is convenient to flag them off --never succeed to fix the apt/packages issues--)

And now if the functions based on Eigen are call, a smart message is issue if compilation without Eigen ...

Later I will add CHOLDC/CHOLSOL but I did not finish rewriting of the tests.

And I also add two useful functions : computing Allan variance in 1D array, and also normalized Median Abs. Dev. Contributions on Allan var. code very welcome.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (724af54) 42.00% compared to head (134afcf) 42.00%.

:exclamation: Current head 134afcf differs from pull request most recent head 45db02b. Consider uploading reports for the commit 45db02b to get more accurate results

Files Patch % Lines
src/datatypes.cpp 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1741 +/- ## ======================================= Coverage 42.00% 42.00% ======================================= Files 361 361 Lines 96912 96912 Branches 19908 19908 ======================================= + Hits 40705 40707 +2 + Misses 56207 56205 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alaingdl commented 7 months ago

I have to add another change but no time now, please no merge now

GillesDuvert commented 7 months ago

@alaingdl please merge at your convenance.