gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

Improvements on WIDGET_TABLE #1745

Closed GillesDuvert closed 7 months ago

GillesDuvert commented 7 months ago

Added editor support and corrected many many errors. Still not able to edit Struct values and does know about set_text_select and use_text_select. But TABLE_SELECTions are OK, on bith normal and disjointed modes. FORMAT is also respected in read and write of values.

For the record, WIDGET_TABLE initial implementation (object oriented) was based on a misinterpretation of the IDL documentation that could not be easily tested on the simple examples then used.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 533 lines in your changes are missing coverage. Please review.

Comparison is base (d12b91c) 41.93% compared to head (dff66f7) 41.87%.

Files Patch % Lines
src/gdlwidget.cpp 0.00% 338 Missing :warning:
src/gdlwidgeteventhandler.cpp 0.00% 108 Missing :warning:
src/widget.cpp 0.00% 52 Missing :warning:
src/gdlwidget.hpp 0.00% 33 Missing :warning:
src/shm.cpp 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1745 +/- ## ========================================== - Coverage 41.93% 41.87% -0.07% ========================================== Files 361 361 Lines 96710 96857 +147 Branches 19833 19835 +2 ========================================== Hits 40558 40558 - Misses 56152 56299 +147 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.