codecov[bot]
commented
7 months ago Codecov Report
Attention: 202 lines in your changes are missing coverage. Please review.
Comparison is base (
d12b91c) 41.93% compared to head (1d1336e) 42.00%.
| Files | Patch % | Lines |
|---|---|---|
| src/basic_op_new.cpp | 46.69% | 113 Missing :warning: |
| src/basic_op_div.cpp | 45.23% | 69 Missing :warning: |
| src/basic_op.cpp | 61.53% | 20 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1747 +/- ## ========================================== + Coverage 41.93% 42.00% +0.06% ========================================== Files 361 361 Lines 96710 96912 +202 Branches 19833 19908 +75 ========================================== + Hits 40558 40705 +147 - Misses 56152 56207 +55 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
many changes to avoid regression introduced by the replacement of sigsetjmp() method (to be avoided and not reporting correctly exceptions) in #1683. Cut-and-paste of new code would result in not testing (and preventing) integer division by zero that is not an exception but a segfault (on our linuxes at last). Found in the process a few places where some speed improvements was yet possible.