detail(s) in the script "build_gdl.sh"

[alaingdl]

This script is working fine ! thanks

1/ Should be simple, but :

On a fresh copy (or git clone) the script need an extra step : git submodule update --init

Could you add this line git submodule update --init or the alternative with -- recursive at the right place in the script ?

I tried to find the place, without success

2/ more tricky

Could also possible to easily switch off packages in the first stages of the script ? EG : I don't need Qhull, and also on U20 & U18 we do have trouble with Image Magick (a sub packet is broken/missing)

[GillesDuvert]

@alaingdl as for general user the script is only available after getting the gdl sources, and mostly by downloading the release tarball, not by using git, it cannot be possible to use a git command in it for general use. build_gdl.sh could however make some introspection (?) to deduce it was the product of a git clone command, and in this case issue a git submodule update --init in the section called by build_gdl.sh prep, but that begins to be complicated...

Concerning the second request, I think it is easy to overwrite all the cmake -DXXX options found in build_gdl.sh, this is basic bash after all.

[pjb7687]

1) I think you can check the existence of the submodule with 'if' statement first. If it does not exist, then issue submodule update command. If the source tree is from tarball, then the directory will exist then no git command will be issued; otherwise, it should have been cloned via git, and git submodule update will work

2) You can already do this with env vars. e.g.,

WITH_GRAPHICSMAGICK=OFF ./build_gdl.sh build

However at the moment QHULL is mandatory and cannot be omitted.

[brandy125]

I like this two solutions.

On 7. Mar 2024, at 11:52, Jeongbin Park @.***> wrote:

I think you can check the existence of the submodule with 'if' statement first. If it does not exist, then issue submodule update command. If the source tree is from tarball, then the directory will exist then no git command will be issued; otherwise, it should have been cloned via git, and git submodule update will work

You can already do this with env vars. e.g.,

WITH_GRAPHICSMAGICK=OFF ./build_gdl.sh build However at the moment QHULL is mandatory and cannot be omitted.

— Reply to this email directly, view it on GitHub https://github.com/gnudatalanguage/gdl/issues/1773#issuecomment-1983673590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOC5K6FWJ76MEU5LB7PYTW3YXB5KXAVCNFSM6AAAAABEJ4YPPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGY3TGNJZGA. You are receiving this because you are subscribed to this thread.

[GillesDuvert]

WITH_GRAPHICSMAGICK=OFF ./build_gdl.sh build does not seem to work on OSX ?