search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

Solved "multiply defined" error messages occuring at link time for some compilers. #1776

Closed GillesDuvert closed 5 months ago

GillesDuvert commented 5 months ago

Enabled "dataypes.cpp" to #include all the other files where templates for the various basic gdl functions were written.

And added SPLIT_SOURCES_FILES option to cmake, triggering (if cmake is called with -DSPLIT_SOURCES_FILES=OFF) this inclusion and preventing the smaller definition files to be compiled separately.

This avoids the "multiply defined ..." errors that happen on some (old?) compilers.

Also, removed many #include that were not necessary.

Close at least 3 issues.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.70%. Comparing base (20545ef) to head (95f6d75). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1776 +/- ## ========================================== - Coverage 42.72% 42.70% -0.02% ========================================== Files 361 361 Lines 97320 97331 +11 Branches 19918 19928 +10 ========================================== - Hits 41576 41570 -6 - Misses 55744 55761 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.