codecov[bot]
commented
5 months ago Codecov Report
Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 42.66%. Comparing base (
1251608) to head (ebfa961). Report is 4 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| src/envt.hpp | 77.77% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1778 +/- ## ========================================== - Coverage 42.70% 42.66% -0.05% ========================================== Files 361 361 Lines 97331 97334 +3 Branches 19928 19928 ========================================== - Hits 41570 41526 -44 - Misses 55761 55808 +47 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
contrary to its intent, the loop number did not start at 0 but at 32 (the initialized default size), and would be constantly increasing in size at each new level of nested loop (remember, ForInfoListT was designed exactly for the contrary!). May even had an incidence on the loop speed.
For the record, using a simpler std::vector would be a lot less worry but would crash when the type of the loop iterator would change during the loop, which happens (see #1540).