search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

Build failure with latest git snapshot #1791

Open opoplawski opened 5 months ago

opoplawski commented 5 months ago

Trying to build the latest weekly snapshot release on Fedora Rawhide with python 3.12.2 I'm getting:

/home/orion/fedora/gdl/gdl-unstable-41ca272/src/pythongdl.cpp:287:61: error: ‘SigFPEHandler’ was not declared in this scope; did you mean ‘oldSigFPEHandler’?
  287 |   PyOS_sighandler_t oldSigFPEHandler   = PyOS_setsig(SIGFPE,SigFPEHandler);
      |                                                             ^~~~~~~~~~~~~
      |                                                             oldSigFPEHandler
/home/orion/fedora/gdl/gdl-unstable-41ca272/src/pythongdl.cpp: In function ‘PyObject* GDL_script(PyObject*, PyObject*, PyObject*)’:
/home/orion/fedora/gdl/gdl-unstable-41ca272/src/pythongdl.cpp:467:63: error: ‘SigFPEHandler’ was not declared in this scope; did you mean ‘oldSigFPEHandler’?
  467 |     PyOS_sighandler_t oldSigFPEHandler   = PyOS_setsig(SIGFPE,SigFPEHandler);
      |                                                               ^~~~~~~~~~~~~
      |                                                               oldSigFPEHandler
GillesDuvert commented 5 months ago

@opoplawski thanks, strange that this was not checked by our GH builds. SigFPEHandler was removed recently in favor of another method. Probably harmless to remove any reference to it in the pythongdl.cpp code.

GillesDuvert commented 4 months ago

removed lines referring to SigFPEHandler in pythongdl.cpp. Hope you'll have better luck this time. Tanks for the report!