search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

Update codecoverage to use actions/checkout@v4 #1794

Closed jkohnert closed 5 months ago

jkohnert commented 5 months ago

Fix Node-16 depcrations message for codecoverage.

alaingdl commented 5 months ago

Could you please explain a little mode or give a like to document that, thank ! (is that link relevant ? https://github.com/actions/setup-node/issues/850 )

jkohnert commented 5 months ago

Pretty much, yes. The codecov job issues a warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3.5.2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Reading though this documentation leads to this page suggesting v4 (or, v4.2.0, if one wants to be more specific).

I'm not too familiar with github's actions, since we're using gitlab at work, and I use gitlab privately, too, but as far as I can tell,this should be the way to go.

I later saw, the probably outdated action is used at more places, maybe I should use this PR to update those usages, too. What do you think?

Best regards Jan

slayoo commented 5 months ago

example here: image (https://github.com/gnudatalanguage/gdl/actions/runs/8485091812)

Thanks @jkohnert !

alaingdl commented 5 months ago

Thanks you, I never noticed because I jump immediately to the red cross item !