search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

to be thoroughly tested, should close #1796 #1799

Closed GillesDuvert closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 43.89%. Comparing base (e1d7f28) to head (b0d8545). Report is 4 commits behind head on master.

:exclamation: Current head b0d8545 differs from pull request most recent head 0fb7ce9. Consider uploading reports for the commit 0fb7ce9 to get more accurate results

Files Patch % Lines
src/FMTOut.cpp 60.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1799 +/- ## ========================================== - Coverage 43.89% 43.89% -0.01% ========================================== Files 376 376 Lines 97442 97447 +5 Branches 19888 19889 +1 ========================================== + Hits 42769 42771 +2 - Misses 54673 54676 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alaingdl commented 4 months ago

what is the status of this PR (not clear for me, relation with the next one ?)

GillesDuvert commented 4 months ago

what is the status of this PR (not clear for me, relation with the next one ?)

they are independent - this one should probably be merged first.

alaingdl commented 4 months ago

We do have to add a test on that ... I will do that ASAP.

In fact the test test_formats.pro gives a problem, this problem appeared between 2023/10/20 and 2023/11/14 and I suspect it is due to the line :

diff gdl-1.0.3git231114CMake/src/calendar.cpp gdl-1.0.3git231020/src/calendar.cpp
98c98
<     if ((DLong)Z+1 > 0) dow = ((DLong)Z+1) % 7; else dow = ((DLong)Z+1099) % 7; //just translate axis...
---
>     if ((DLong)Z > 0) dow = ((DLong)Z) % 7; else dow = ((DLong)Z+1099) % 7; //just translate axis...

@GillesDuvert do you remember the reason of this change ?

IDL and GDL older than 2023/10/20 :

print,2.455555555D6,format='(c())'
Sat Dec 25 01:19:12 2010

GDL since 2023/11/14

GDL> print,2.455555555D6,format='(c())'
Sun Dec 25 01:19:12 2010

In fact, I don't know why test_formats.pro is not in the LIST file.

GillesDuvert commented 4 months ago

This looks like an error/typo . The previous version was correct, as Julian 2455556L is a saturday, not sunday. Can you correct directly in GH?