search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
270 stars 61 forks source link

enable T TR and TL codes. Wonder why they did not work and, more, why… #1800

Closed GillesDuvert closed 2 months ago

GillesDuvert commented 3 months ago

… the ANTLR code was special for TR and TL. removed this special treatment and did not see any problem arising elsewhere (passes tests). This should be thorougly tested.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 43.85%. Comparing base (7b39974) to head (cc8e339). Report is 18 commits behind head on master.

Files Patch % Lines
src/FMTLexer.cpp 14.58% 41 Missing :warning:
src/FMTParser.cpp 53.33% 28 Missing :warning:
src/FMTOut.cpp 19.04% 17 Missing :warning:
src/FMTIn.cpp 0.00% 1 Missing :warning:
src/FMTIn.hpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1800 +/- ## ========================================== - Coverage 43.89% 43.85% -0.05% ========================================== Files 376 376 Lines 97442 97477 +35 Branches 19888 19887 -1 ========================================== - Hits 42769 42744 -25 - Misses 54673 54733 +60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alaingdl commented 3 months ago

For sure I am OK to review but I need some time, and not sure when during next few days

alaingdl commented 3 months ago

@GillesDuvert sorry it seems we have a conflit here (maybe my fault)

GillesDuvert commented 2 months ago

oulah, the conflict is very serious, apparently github takes the WRONG source. This happened in the past. Cannot figure how it is possible. GRRRRRRRR I'll be obliged to resubmit after scrutinizing the b**** code.