search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
270 stars 61 forks source link

Remove dangerous code in ANTLR gdlc.g #1805

Open GillesDuvert opened 3 months ago

GillesDuvert commented 3 months ago

One needs to remove the patch made by Marc in gdlc.g (revision 6a61cee on Aug 23,2014). This patch explictely introduces (in primary_expr_deref) a compilable C++ code that depend on the tokenSets generated by ANTLR, which in return depend on the changes made elsewhere in gdlc.g . This is not maintainable and apparently is the cause of some slowness, if not errors. Primary tests without this patch show now problems in all test at our disposal and may also show a slight increase of compilation speed. Not to speak about simplifying the maintainance of this important code, the base language interpretor.

GillesDuvert commented 2 months ago

In previous text read "show NO problems" instead of "show now problems"