search

gnudatalanguage / gdl

GDL - GNU Data Language
GNU General Public License v2.0
274 stars 61 forks source link

Cmakefix #1850

Closed ChunkyPanda03 closed 2 months ago

ChunkyPanda03 commented 3 months ago

I found a couple of errors while compiling I saw that this project uses imagemagick-7 not imagemagick-6 as shown here #https://github.com/gnudatalanguage/gdl/issues/1578#issuecomment-1519117266 and I think the reason it is not automatically looking for the correct version. I have added it into the the FindImageMagick. Also a slight note that debian 12 has only imagemagick-6 and cmake recommends that you install it.

test_dynamic_drivers.pro had an error that would prevent the test from setting the resolution which I think was not exiting correctly I now have a few plotting tests failing now but I think this is a personal dependency issue I would like to personally resolve before discussing further.

For the git ignore these files were added to the working directory by the setup script you can choose whether to keep this change or not.

GillesDuvert commented 2 months ago

@ChunkyPanda03 thanks for the PR, just a doubt: you changed set_resolu to set_resolution in test_dynamic_drivers but there should have been no error there, the abbreviation was long enough to avoid confusion?

ChunkyPanda03 commented 2 months ago

yeah @GillesDuvert I realized that set_resolution is the same as the default it was likely failing for me because of a dependency issue when building on my machine... still tracking that one down.