search

gnukman / pidgin-guiops

Automatically exported from code.google.com/p/pidgin-guiops
0 stars 0 forks source link

[patch]problem make switching input method with Shift failing #5

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

1. Install and enable pidgin-guiops
2. Install fcitx or ibus
3. Set the Chinese/English switching key to Shift
3. Try to switch between Chinese mode and English mode with the Shift key in 
the conversation window

What is the expected output? What do you see instead?

It should switch between Chinese and English. But it does not.

What version of the product are you using? On what operating system?

I'm using pidgin-guiops 0.5RC1, on FreeBSD 8.2-STABLE

Please provide any additional information below.

OK, the problem is that the callback function for key-release-event needs a 
gboolean value for return. If it is TRUE, then other handlers will not be 
notified of the key event, and if it is FALSE, then the processing will 
continue.
However, you registered it with a function which returns void, so the return 
value is decided by something strange, maybe the temporary value in the 
registers. Coincidentally it returned TRUE for normal keys, but it returned 
FALSE for a single shift press. So the problem appears.

I'm attaching a patch which fixes the problem. Please review it. Thank you.

Original issue reported on code.google.com by Henry.Hu...@gmail.com on 13 Sep 2011 at 12:16

Attachments:

GoogleCodeExporter commented 8 years ago 
Patch accepted and applied to 0.5RC2. Will be available for download soon.

Original comment by daspo...@gmail.com on 13 Nov 2011 at 5:39