Build setup; environment variable-based config

gnulag / circ

#gnulag's IRC bot

BSD 2-Clause "Simplified" License

3 stars 3 forks source link

Closed flotwig closed 5 years ago

flotwig commented 5 years ago

This PR:

[x] Adds build.sh, which uses cmake and make to build all .c and .h files under lib
[x] Adds start.sh, which supplies basic environment variables and launches ./bin/circ
[x] Adds lib/config, which reads in config variables from environment to C strings
[x] Adds lib/log, with basic info- and debug-level logging statements
[x] Updates main.c to print out the loaded config variables before exiting
[x] Adds build instructions to README.md

My C-fu is weak, but this is better than nothing!

flotwig commented 5 years ago

Split up the log so I could respond to changes:

Nice - updated it to do exactly that. This is way better.
Hmm, I like the glob, I think it makes more sense to do it that way vs. updating the CMakeLists.txt for every new file. Is there a technical reason that we shouldn't?
Let's break away from C style and use braces on the same line, I think most people in #gnulag prefer it. I'd also be open to using an autoformatter on pre-commit or something, but that'd probably be a separate PR.
Fixed.

rkitover commented 5 years ago

Various reasons not to use GLOB see:

flotwig commented 5 years ago

Makes sense. Updated.