search

gnulag / circ

#gnulag's IRC bot
BSD 2-Clause "Simplified" License
3 stars 3 forks source link

Private Messages may cause an infinite loop #35

Closed maxaudron closed 4 years ago

maxaudron commented 5 years ago

When sending a PM to circ there is a potential for an endless loop. This is caused by us taking the first argument of the IRC Raw Message as a return address, which is correct for channels but not for PMs.

A PM Message

:audron!audron@user/audron PRIVMSG circ :%ping
                                    ^ we use this argument

We will need to implement a check for if this argument is our own name, and if it is we need to use the prefix to send the reply

pta2002 commented 5 years ago

I can work on this today, doesn't look like a big issue