search

gnulib-modules / bootstrap

a clean rewrite of gnulib bootstrap for scriptable extensibility and proper error reporting
Other
8 stars 6 forks source link

multiple --local-dir equivalent for bootstrap.conf #1

Closed gvvaughan closed 8 years ago

gvvaughan commented 8 years ago

gnulib-tool supports multiple --local-dir options to add multiple local module directories, where bootstrap simply extracts gl_LOCAL_DIR from gnulib-cache.m4 into the shell variable local_gl_dir from func_require_local_gl_dir.

It should be possible to specify multiple directories in bootstrap.conf too, for equivalence to the command line when bootstrap calls gnulib-tool.

I don't know how (or even whether) multiple directories are stored in gnulib-cache.m4, but they should be extracted correctly, and then passed back in to gnulib-tool invocations as multiple --local-dir settings too.

praiskup commented 8 years ago

I believe this has been addressed both in bootstrap and gnulib. https://github.com/gnulib-modules/bootstrap/commit/73e8fb0d68351753 http://git.savannah.gnu.org/cgit/gnulib.git/tree/gnulib-tool#n5301

praiskup commented 8 years ago

There is one issue in gnulib code I'm aware of -- if PATH_SEPARATOR is ;, then this character is used as separator also in gl_LOCAL_DIR. There should be always used colon to have the gnulib-cache.m4 file generated consistently everywhere.

gvvaughan commented 8 years ago

agreed on both counts.

Your recent patches to bootstrap seem to fix the other end of this issue too. Thank you :)