search

gnulib-modules / bootstrap

a clean rewrite of gnulib bootstrap for scriptable extensibility and proper error reporting
Other
8 stars 6 forks source link

Old libtool fix about wrong locales handling has been lost in refactory #24

Closed falemagn closed 3 years ago

falemagn commented 3 years ago

Hi,

I have encountered an issue that has been raised, and fixed, in libtool about 11 years ago. Here's the relevant discussion: https://lists.gnu.org/archive/html/bug-libtool/2010-03/msg00002.html

I understand during these years libtool has undergone great transformations, so that fix must have been lost during some refactory.

TL;DR: if locale-specific environmental variables aren't set, then funclib.sh doesn't change their value to "C", which seems fine, until you meet MINGW, which defaults to windows locale if the relevant environmental variables aren't set.

This is what happens on my system: windows's set to use the Italian language, and LANG, LC_ALL and the rest are empty. Hence, objdump speaks windows-Italian, but libtool speaks English, and they don't understand each other, causing the problems highlighted 11 years ago.

I guess the fix is the same as the one from those days: Unconditionally normalize LC_ALL, LANGUAGE

praiskup commented 3 years ago

Thank you Fabio for the detailed report. Please take a look at #26.