search

gnumpi / esphome_audio

Custom audio components for ESPHome
Other
62 stars 23 forks source link

Offering help if needed #27

Open X-Ryl669 opened 7 months ago

X-Ryl669 commented 7 months ago

Hi,

I've been linked to your repository via here. I've implemented an update to ESP-ADF component to support the latest version and sharing I2C bus with ESP-ADF's format and ESPHome. My work is here

I think it can be useful to merge my changes (at least for using the last ESP-ADF and dependencies version). There were a lot of pitfalls I had to fix (like the esp-dsp dependency, the I2C issue, the esp-adf incompatibility with C and C++ structure definitions and so on). So it might be save you a lot of time to avoid redoing this.

Let me know if you need it.

gnumpi commented 7 months ago

Hey, sounds really interesting. Do I get it right that supporting the ADF-I2C let you use the DACs and ADCs supported by the ADF-boards? I also added some DAC and ADC support to the I2S_audio component in this repository. Would be awesome to add the ADF-boards right away. Could you share a config which makes use of your change to get a better understanding?

X-Ryl669 commented 7 months ago

Do I get it right that supporting the ADF-I2C let you use the DACs and ADCs supported by the ADF-boards?

Yes. The (HW) components supported by ADF are now accessible directly and no need to replicate those in ESPHome, while still maintaining access to ESPHome's I2C devices (like AHT sensor on BOX3, Radar, etc...).

Could you share a config which makes use of your change to get a better understanding?

https://github.com/esphome/issues/issues/5296#issuecomment-2039156195

For the change itself, please have a look here, it's not too big in fact And BTW, Espressif merged my change to ADF to support external I2C bus integration, so the upcoming versions will have it without a link to my fork.

gnumpi commented 7 months ago

Really great news! I will try to integrate the esp_codec_dev devices into the adf_pipeline component then. Thanks for offering your help! If it's ok, I will come back to you when I have a rough beta version and see what you think.