search

gnunicorn / clippy-service

Linting your rust project with clippy as a service
GNU Affero General Public License v3.0
36 stars 9 forks source link

Decide how to handle libs with external dependencies #23

Open badboy opened 8 years ago

badboy commented 8 years ago

Reporting this so it might get tackled sometime (I don't expect this to work right now)

One of my projects depends on external libs that itself need cmake to build. The clippy build therefore fails: http://clippy.bashy.io/github/sha/semantic-rs/semantic-rs/6588cacc9f6318602b726d13272605fabf099fa2/log

It's unlikely that in the current form clippy-service is able to provide a way to make this work yet.

gnunicorn commented 8 years ago

Well, we could simply add cmake to the tools made available to clippy-minion, or is there something I don't see here? We already – technically – allow gcc and such, I don't see how this would be different...

badboy commented 8 years ago

Of course adding cmake would solve it for me, but who knows what dependencies others will need? A decision should be made if it will be best effort (meaning dependencies will be added as projects require them) or it will be kept bare bones (leaving some projects behind).

gnunicorn commented 8 years ago

Hmmm.. I think common build tools like cmake could really just be added. I have not yet heard about any other use cases, but am thinking we might want to allow "system-dependencies" to be something that users can configure and we'd install (apt-get installables only) before running rustc. We'd just substract the runtime of that from the global runtime limit that the lib has before we kill its compiling process to ensure people don't do evil things.

But that is future talk. I'd accept a PR that adds cmake and therefor fixes this specific issue.

badboy commented 8 years ago

:+1: