gnunn1 / tilix

A tiling terminal emulator for Linux using GTK+ 3
https://gnunn1.github.io/tilix-web
Mozilla Public License 2.0
5.38k stars 293 forks source link

tilix --quake --full-screen #1306

Open emanuk opened 6 years ago

emanuk commented 6 years ago
Linux Mint 18.3
 Versions                           
        Version de Tilix : 1.7.5   
        Version de VTE : 0.42      
        Version de GTK : 3.18.9    

Fonctionnalités spéciales de Tilix 
        Notifications activées=0   
        Déclencheurs activés=0     
        Badges activés=0           

Hello, first thanks for Tilix, it's so great.

I use Tilix in quake mode in full screen and I noticed that when I use either vim or tmux with a status bar, the window sometimes have to be redrawn with Ctrl-l ('L') or touching any key on the clipboard.

The status bar is at the edge of what is the original quake window without fullscreen and then, it will go down the window by itself, of I have to do Ctrl-l or touch a key on the keyboard.

And sometimes, the whole content in the window doesn't immediately appear (see pictures attached).

I use a ThinkPad T450S with 12 Go of ram.

I see the problem either putting the quake mode in fullscreen with F11 (full screen for any application on Linux Mint) or with the arg --full-screen

And sometimes this problem appears in quake mode even if the window is not in full screen (see again pictures attached).

Thanks again for Tilix, it's a wonderful terminal.

tilix quake 2 tilix quake

egmontkob commented 6 years ago

Most likely your application doesn't handle it correctly if it receives multiple resize events straight after each other. vim is infamous to suffer from this problem, maybe tmux's status line is also affected.

emanuk commented 6 years ago

@egmontkob thanks for answering but I never experienced that with Quake terminal and Tilda.

gnunn1 commented 6 years ago

@emanuk Tilda is GTK 2 so that may be why it would have some different behaviors. What version of Guake did you try? Until recently Guake was also GTK2 only.

Also, just to confirm this is under X11 and not Wayland?

emanuk commented 6 years ago

@gnunn1 If I'm not mistaken, Linux Mint is under X11/Xorg. The Guake version is 0.8.4.

emanuk commented 6 years ago

@gnunn1 I must say that it seems working perfectly well in non Guake mode.

egmontkob commented 6 years ago

@gnunn1 Tilda is GTK 3.

@emanuk I'm not familiar with Tilix's Quake mode, but if it does any kind of animation (e.g. rolldown) on opening its Quake window then this might very well be relevant.

Even if it doesn't, there's still a chance for two consecutive resize events rather than one. Plenty of terminal emulators (including gnome-terminal) suffer from this ugliness in certain scenarios.

Here's how to check. Have either bash version <= 4.2 or >= 4.4, or zsh running, then execute trap 'stty size' WINCH. Do whatever operation triggers vim to fall apart (without vim running), and study the sizes printed. (This method catches double resizes most of the time, but not necessarily always. The shell might even miss a double resize if it flies in really fast. The foolproof method is to debug VTE.)

emanuk commented 6 years ago

@egmontkob When I go to fullscreen with F11: 66 238 When I go not fullscreen (90x100): 58 238

egmontkob commented 6 years ago

"90x100"? Did you mean "90%" instead?

Only a single pair of numbers printed on F11? Then it's not about consecutive resizes. Please double check that there aren't more pairs of numbers appearing in separate lines.

emanuk commented 6 years ago

@egmontkob This is what I did, I started tilix minified, pasted

trap 'stty size' WINCH

Pressed the return key and got back: 23 80

Then I pressed F11 and then the return key and got back: 69 238

I decided not to use for the moment Tilix in Guake mode since it's not working for me.

fbernier commented 6 years ago

I am experiencing what seems to be the very same issue that I was also not having using other terminals. I use a hotkey to show and hide my terminal, but always in full screen.

On terminal hide, I get 42 159, and on show I get 45 159.

The bottom of nvim resizes / redraws each time my terminal is showing nvim. I also use tmux and run arch linux.

Versions
        Tilix version: 1.7.7
        VTE version: 0.52
        GTK Version: 3.22.29

Tilix Special Features
        Notifications enabled=0
        Triggers enabled=0
        Badges enabled=0
gnunn1 commented 6 years ago

If you disable overlay scrollbars in Preferences | Appearance does that help at all?

fbernier commented 6 years ago

Unfortunately I get the same result (I did restart the terminal).

fbernier commented 6 years ago

here's a video of what it does. You don't see the terminal show/hide but you do see the resize happening: https://asciinema.org/a/Ev5hm0A8b714YsugXlMUSHgIE

fbernier commented 5 years ago

@gnunn1 so I found how this is happening. I just setup a new computer and in quake -> size -> height percent is set to default at 40. Now, when I open tilix using a key binding to launch tilix -q --full-screen, the redraw animation like the video posted above goes up to 60% of the screen.

I went to adjust height percent to the max and the slider stops at 90. After that, the redraw animation on quake show is only to bottom 10% of the screen.

Is there a reason why height percent cannot be 100 ? Or is it possible to have the --fullscreen take priority over the quake-defined height ?

PowerUser64 commented 3 years ago

This is still an issue. When using tilix in fullscreen quake mode (with or without --full-screen), tilix resizes the terminal to the non-fullscreen size for about a frame while it is reappearing. Although this is a small amount of time, it still causes programs to resize themselves to the size of the size of the smaller terminal; wrecking vim splits and other things that assume the terminal width to remain relatively constant.

emanuk commented 3 years ago

Not sure if it can help here but on Debian Buster with Wayland this gnome extensions allow Tilix to run smoothly in quake mode:

Tilix DropDown - Extensions GNOME Shell : https://extensions.gnome.org/extension/1185/tilix-dropdown/

PowerUser64 commented 3 years ago

Thanks for the recommendation. I tried the extension, but unfortunately, all it seems to do is run the tilix --quake command, and the terminal is still resized upon reappearing.