gnunn1 / tilix

A tiling terminal emulator for Linux using GTK+ 3
https://gnunn1.github.io/tilix-web
Mozilla Public License 2.0
5.39k stars 294 forks source link

Flatpack Install fails to lauch from gnome shell (application menu) #1576

Closed sferich888 closed 1 year ago

sferich888 commented 5 years ago
Nov 07 22:40:13 HOSTNAME dbus-daemon[1441]: [session uid=1000 pid=1441] Activating service name='com.gexperts.Tilix' requested by ':1.8' (uid=1000 pid=1544 comm="/usr/bin/gnome-shell " label="unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023")
Nov 07 22:40:13 HOSTNAME systemd[1419]: Started flatpak-com.gexperts.Tilix-3440.scope.
Nov 07 22:40:14 HOSTNAME com.gexperts.Tilix[1441]: bwrap: execvp /usr/bin/tilix: No such file or directory
Nov 07 22:40:14 HOSTNAME dbus-daemon[1441]: [session uid=1000 pid=1441] Activated service 'com.gexperts.Tilix' failed: Process com.gexperts.Tilix exited with status 1

This issue seems to be caused by how gnome is starting or trying to start tilix, from /var/lib/flatpak/app/com.gexperts.Tilix/x86_64/master/active/files/share/dbus-1/services/com.gexperts.Tilix.service however I have not been able to get this behavior to change, but editing this file.

I am able to start the flatpack using the cli, flatpak run com.gexperts.Tilix, but I can't start it using gnome.

$ gnome-shell --version GNOME Shell 3.30.1 $ flatpak --version Flatpak 1.0.4

sferich888 commented 5 years ago

@kirbyfan64 can you have a look at this (as the contributor to the original source). It should probably be said that I am seeing this issue on Silverblue but IDK if that maters.

cc: @alex285 based on the initial commit you did not seem to have this issue have you updated or had any issues like this lately?

refi64 commented 5 years ago

Do you have normal Tilix installed as well? I recall this happening at one point when both the rpm and flatpak were installed, so I had assumed it was a GNOME issue, but I haven't tested in a while.

sferich888 commented 5 years ago

I do not. With Silverblue you have to mess with the rpmos-tree to get packages installed (I'm trying to avoid that).

sferich888 commented 5 years ago

The issue is with export/share/dbus-1/services/com.gexperts.Tilix.service

D-BUS Service]
Name=com.gexperts.Tilix
Exec=/usr/bin/flatpak run --branch=master --arch=x86_64 --command=/usr/bin/tilix com.gexperts.Tilix --gapplication-service~

This should just be --command=tilix

bilelmoussaoui commented 5 years ago

@sferich888 It was already fixed on master https://github.com/gnunn1/tilix/blob/master/data/dbus/com.gexperts.Tilix.service.in#L3

sferich888 commented 5 years ago

I just build from master ~5 days ago (this is still an issue). Or the build istructions are not having you build correctly (as @bindir@ is still getting set to /usr/bin/

refi64 commented 5 years ago

Hmm, I'll try to take a look at this later.

thebitstick commented 5 years ago

Temporary fix until a fix comes: In the flatpak-builder directory, go to exports/share/dbus-1/com.gexperts.Tilix.service and change /usr/bin/tilix to tilix manually And rebuild with --force-clean

bilelmoussaoui commented 5 years ago

The issue is that the Flatpak manifest still uses autotools, this issue was fixed with meson only. We should update the manifest to use the meson buildsystem instead.

sferich888 commented 2 years ago

I think this original issue is fixed but... the flat pack still has issues (example: https://github.com/containers/toolbox/issues/886) feel free to close as resolved.