search

gnunn1 / tilix

A tiling terminal emulator for Linux using GTK+ 3
https://gnunn1.github.io/tilix-web
Mozilla Public License 2.0
5.42k stars 292 forks source link

Tabs are too wide for smaller window sizes #1691

Open parcelcat opened 5 years ago

parcelcat commented 5 years ago

In version 1.9.0 and newer, the minimum tab width is too high. Version 1.8.9 and earlier were able to display many tabs in a 720px width window (at 100% display scale), but the current version can only fit 2 tabs in the same window.

Tilix

gnunn1 commented 5 years ago

Do you see the same behavior when using Adwaita as the gtk theme?

parcelcat commented 5 years ago

Yes, it appears to be the same for Adwaita.

Adwaita Tilix

gnunn1 commented 5 years ago

I cannot reproduce the issue, what is the output of tilix --version?

Also, what do you have set for session title in your configuration?

parcelcat commented 5 years ago

The output of tilix --version is:

Versions
    Tilix version: 1.9.1
    VTE version: 0.56
    GTK Version: 3.24.8

Tilix Special Features
    Notifications enabled=0
    Triggers enabled=0
    Badges enabled=1

The default session name is ${directory}, and the screenshots were taken from the / directory.

dreamcat4 commented 5 years ago

Hello, I also have a similar type of issue. At a certain point, the tabs stop getting smaller. And a limit is hit. On my ultrawide monitor, with 3440-58px width (subtracting the 59px for the dock). Then it stops hard at 13 tabs. (3440-58)/13 = 260.1538461538461px

tilix --version
Versions
    Tilix version: 1.9.1
    VTE version: 0.54
    GTK Version: 3.24.4

Tilix Special Features
    Notifications enabled=0
    Triggers enabled=0
    Badges enabled=1

This is on ubuntu 18.10, budgie desktop 10.5, with the following desktop UI themes:

It would seem that the first one "Widgets" is the main desktop theme.

dreamcat4 commented 5 years ago

Perhaps it could be possible to add a new setting, for defining a "Minimum tab size" ? So if users want many more tabs open, at a smaller width. Vs the other people who would rather prefer to see the Title of the tab text not be truncated so much.

Another point is that ATM (because I cannot see many of my tabs, they are scrolled off the end). Well then can I put a window number at the Front of each tab text? Like 1. <tab_title> for the 1st tab. Then 2. Second Tab and 3. Third Tab Title etc. Because that would make it much easier for me to identify which tab I am currently scrolling over to. When each tab title is otherwise identical. For example I have multiple tabs open all within in the same directory etc. This prefixing of a fixed tab number would also aid navigation when the tab width is too narrow to be truncated. But also when they are scrolling off the screen and look the same. Either way. Just a quick suggestion. Kind regards.

Briffou commented 5 years ago

Still have the issue describe by @articlecat, tabs "don't shrink enough", even on default theme Adwaita (on Fedora 30), tilix --version :

Versions
    Version de Tilix : 1.9.1
    Version de VTE : 0.56
    Version de GTK : 3.24.10

dnf info tilix :

Nom          : tilix
Version      : 1.9.3
Publication  : 1.fc30
Architecture : x86_64
Taille       : 4.0 M
Source       : tilix-1.9.3-1.fc30.src.rpm
Dépôt        : @System
Depuis le dé : updates
Résumé       : Tiling terminal emulator
URL          : https://github.com/gnunn1/tilix
Licence      : MPLv2.0 and GPLv3+ and CC-BY-SA
Description  : Tilix is a tiling terminal emulator with the following features:

Note: It also seems that the tilix version is not consistent between the two outputs.

Briffou commented 5 years ago

As this behaviour was quite annoying for me, I investigated a little bit more, and find that setting hhomogeneous parameter to false for the GtkStack introduced in https://github.com/gnunn1/tilix/commit/552923400bada2f0a1960e4b9a29b8588d46be31 seems to help a lot, see https://github.com/Briffou/tilix/commit/8e9ba0fe9343da3d57d9c3eae490e594a3586ad4

As I know anything in Gtk and Tilix code, I'm quite hesitant to make a PR, but if a maintainer confirms me that it's a good correction, I'll do it.

Before/after comparison:

Before, I could only open 3 tabs before left and right arrows appears on each side of the window (no matter what was the active theme) : before

After setting hhomogeneous parameter to false, I can open up to 8 tabs : after

dreamcat4 commented 5 years ago

Cool man.... @gnunn1 can you please take a loot at this? Seems like a pretty good idea.

wallneradam commented 5 years ago

I recompiled Tilix (on Ubuntu 19.10) with the patch @Briffou did, and it works as I think it should.

andrehtgti2 commented 4 years ago

Hi! I am using Ubuntu 19.10 and Tilix 1.9.1 and the tab width is still too wide I installed tilix via apt-get install tilix Is there a solution ?

tilix --version Versions Tilix version: 1.9.1 VTE version: 0.58 GTK Version: 3.24.12 Tilix Special Features Notifications enabled=0 Triggers enabled=0 Badges enabled=1

Pajn commented 4 years ago

I have this problem too, is it possible to set hhomogeneous to false without recompiling?

andrehtgti2 commented 4 years ago

Any new version to fix this ?

unixfox commented 3 years ago

image

I've the same issue on KDE Plasma 5. The buttons are way too big also for some unknown reason.

Versions
    Tilix version : 1.9.1
    VTE version : 0.62
    GTK Version : 3.24.24

Tilix Special Features
    Notifications enabled=0
    Triggers enabled=0
    Badges enabled=1
mrliptontea commented 3 years ago

Same issue here. On my screen, I can only open 5 tabs before they get the side-scrolling arrows. By comparison in GNOME Terminal I can open 20+ tabs before they start scrolling and the tab UI there is identical.

jmdeejay commented 3 years ago

I think we should merge the fix suggested by @Briffou. It does the job for me. Else I have to reverse to an old version of tilix (1.8.9) in order to have manageable tabs.

IzhakJakov commented 3 years ago

:+1:

ronny-rentner commented 4 months ago

I have the same problem, tabs are too wide. :(