search

gnunn1 / tilix

A tiling terminal emulator for Linux using GTK+ 3
https://gnunn1.github.io/tilix-web
Mozilla Public License 2.0
5.38k stars 293 forks source link

bugfix: fix std.xml deprecation warning #2101

Closed Jiehong closed 2 years ago

Jiehong commented 2 years ago

Fixing the only warning I see:

source/gx/tilix/prefeditor/prefdialog.d(960,16): Deprecation: module `std.xml` is deprecated - Will be removed from Phobos in 2.101.0. If you still need it, go to https://github.com/DigitalMars/undeaD

Everything seems to be the same other than that.

Jiehong commented 2 years ago

The meson builds now fail. Any idea how to fix them? They say they can't read undead.xml now, but I've never used meson/ninja before.

yochananmarqos commented 2 years ago

If this was merged, Tilix would have to depend on libundead. Not many distros package that.

Jiehong commented 2 years ago

If this was merged, Tilix would have to depend on libundead. Not many distros package that.

@yochananmarqos : you're right, it seems it's only present in Ubuntu/Debian repositories.

But it's missing from NixOS, Archlinux and Fedora.

Closing this then.

ximion commented 2 years ago

You may be able to entirely replace the little XML parsing that Tilix does with GLib's own GMarkup parser: https://developer-old.gnome.org/glib/stable/glib-Simple-XML-Subset-Parser.html

yochananmarqos commented 1 year ago

@Jiehong Well, Arch just did it anyway using the upstream undeaD tarball, see https://github.com/gnunn1/tilix/issues/2151#issuecomment-1439331926