gnunn1 / tilix

A tiling terminal emulator for Linux using GTK+ 3
https://gnunn1.github.io/tilix-web
Mozilla Public License 2.0
5.34k stars 294 forks source link

Change label of "view shortcuts" action #2180

Closed waldyrious closed 8 months ago

waldyrious commented 11 months ago

The previous label ("View configured shortcuts") implied that what would be shown was only the shortcuts that were explicitly configured (by the user), but this is not the case.

The new label ("Show keyboard shortcuts") removes the ambiguity, uses a verb whose actor is the program (in line with the other actions) and explicitly mentions the term keyboard shortcuts, for extra clarity.

ximion commented 8 months ago

I don't see this as confusing, but the second rationale does make sense to me given the wording for the other actions. So while minor, this change looks fine! Thank you for the patch!