search

gnuradio / gnuradio

GNU Radio – the Free and Open Software Radio Ecosystem
https://gnuradio.org
GNU General Public License v3.0
4.9k stars 1.87k forks source link

Metadata file sink doesn't reflect modified/deleted item tags #3516

Open eprucka3 opened 4 years ago

eprucka3 commented 4 years ago

@ejk43

If a tag is modified or deleted from a stream, the tag does not change and continues to be displayed in every following packet in the metadata file sink.

metadata_demo

In this case, a Tags Strobe adds a tag at packet 10. It should be displayed in a single packet, such as in the middle packet shown in the capture from the Tag Debug. After the strobe in the middle tag, it is correctly not displayed again in the following packet.

tags

However, in the file metadata sink header, the tag is displayed in every packet after the first strobe. Although the strobe tag should only be displayed in packet 10, it is propagated to packet 11 as well.

tagged_metadata

marcusmueller commented 5 months ago

can reproduce. Serious bug, as it affects recordings. repro3516

https://gist.github.com/marcusmueller/78dac4f3ae76de87da18d60fc0487c84

marcusmueller commented 5 months ago

Tagging this "Runtime" and "TSB", because something's fishy here.

marcusmueller commented 2 days ago

by the way, this happens with inline headers too, and the block only sees the correct tags.