search

gnuradio / gnuradio

GNU Radio – the Free and Open Software Radio Ecosystem
https://gnuradio.org
GNU General Public License v3.0
5.01k stars 1.89k forks source link

Deprecating Clock Recovery MM #5556

Open 777arc opened 2 years ago

777arc commented 2 years ago

https://github.com/gnuradio/gnuradio/blob/120268de56dbf1a1ab01e27c601cd7d1342afaf7/gr-digital/grc/digital_clock_recovery_mm_xx.block.yml#L3

If we are actually going to remove Clock Recovery MM we need to first have a 1:1 mapping of Clock Recovery MM params -> Symbol Sync params, because plenty of folks are going to have no idea how to actually do the switch.

Honestly I wouldn't be against just unmarking it deprecated and instead having a huge banner at the top of the Block Docs for Clock Recovery MM saying "if you're using this block in a new flowgraph, we suggest Symbol Sync instead".

solomonbstoner commented 2 years ago

We had an inconclusive discussion about the mapping when I wanted to replace Clock Recovery MM with Symbol Sync on one of the hier block. The issue was - what to do with the mu parameter. Im not sure what has happened since

marcusmueller commented 7 months ago

tagging as low prio, because this is only important for straightforward porting, and FGs using the deprecated block have gotten rare. Not a good "solution", but realistic…