search

gnuradio / pmt

pmt
GNU Lesser General Public License v3.0
11 stars 11 forks source link

Added license to beginning of all c++ files. #10

Closed jsallay closed 2 years ago

jsallay commented 2 years ago

I didn't add the license to the files in the bench directory because I believe that those were copied from elsewhere. I also didn't add anything to the fbs file. I can add something in those cases if desired.

dkozel commented 2 years ago

@jsallay Two thumbs up on adding the licenses using SPDX, but several temp binary files snuck into the commit.

jsallay commented 2 years ago

@jsallay Two thumbs up on adding the licenses using SPDX, but several temp binary files snuck into the commit.

Good catch. Fixed.

dkozel commented 2 years ago

Thanks. Also you've added .github/workflows/build_and_test.yml which is unrelated and looks like it's causing a CI error now.

jsallay commented 2 years ago

Thanks. Also you've added .github/workflows/build_and_test.yml which is unrelated and looks like it's causing a CI error now.

The file was already there, but it wasn't working. It looks like when it was split out from the main newsched, a few items like installing the flatbuffers compiler didn't get transferred over. I'll open a new issue for @mormj to look at.

mormj commented 2 years ago

I've put flatc into the ci docker now, so the updates to build_and_test.yml can be removed from the PR and it should build fine.

jsallay commented 2 years ago

Thanks, I'll try it out tonight.

John

On Mon, Sep 27, 2021, 11:12 AM mormj @.***> wrote:

I've put flatc into the ci docker now, so the updates to build_and_test.yml can be removed from the PR and it should build fine.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gnuradio/pmt/pull/10#issuecomment-927970728, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPWDXEPUHTO4WXOQW2SINTUECCUXANCNFSM5EX63JCQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.