Clang fixes - Githubissues

gnuradio / pmt

pmt

GNU Lesser General Public License v3.0

11 stars 11 forks source link

Clang fixes #61

Closed jsallay closed 2 years ago

jsallay commented 2 years ago

Clang is stricter than gcc when it comes to implementing the standards. Specifically here:

Fix an instance where a forward declaration of a class was declared as a struct.
Clang does not allow for template arguments when specializing a template class constructor
nullptr_t must be referenced as std::nullptr_t
The resolution order of overloaded functions is not as forgiving. Had to tighten the SFINAE on several operator== calls.

Also, there is a bug with clang and pybind11 that was fixed in a recent version. Add a version check to the meson.build with a workaround.

jsallay commented 2 years ago

This should close out https://github.com/gnuradio/pmt/issues/57 and https://github.com/gnuradio/pmt/issues/58