search

gnuradio / pmt

pmt
GNU Lesser General Public License v3.0
11 stars 11 forks source link

Ci add clang #82

Closed wirew0rm closed 1 year ago

wirew0rm commented 1 year ago

This adds builds for clang along to the existing ones for c++ to github actions to ensure that pmt also builds with clang.

For now the clang build is broken.

I had to switch the image for a modified one as the one by @mormj did not include clang. I'll add a PR for that so it can be switched back to the original image(by removing the last commit) before merging.

jsallay commented 1 year ago

This should work now. We merged in fixes for the compile issues. The commits aren't properly signed though. Can you follow the instructions here: https://github.com/gnuradio/pmt/pull/82/checks?check_run_id=12310931972.

You might need to a signing key to gitlab as well.

wirew0rm commented 1 year ago

signed and rebased onto main to include the clang fixes.

wirew0rm commented 1 year ago

I'd still like to move the used CI image back to josh's, that's why it was still marked as draft as long as that PR is still pending. (long term that will probably be included into https://github.com/gnuradio/gnuradio-docker ?)