gnuradio / pmt

pmt
GNU Lesser General Public License v3.0
11 stars 11 forks source link

Set meson warning_level and fix issues. #93

Closed jsallay closed 1 year ago

jsallay commented 1 year ago

Meson makes it pretty easy to set warnings consistently across compilers via the warning level. For gcc and clang warning_level=3 sets -Wall, -Wextra, and -Wpedantic.

I tried the next level which does -Weverything but that caused a lot of issues. There were a lot of warning found in the dependencies (refl-cpp and fmt especially). I also had a lot of false positive errors. For example, a warning staying that the code was implicitly casting between types when it was actually explicitly casting.

I fixed all but one of the issues that were found by the compiler.