search

gnuradio / pmt

pmt
GNU Lesser General Public License v3.0
11 stars 11 forks source link

Remove compiler's warnings. #98

Closed drslebedev closed 1 year ago

drslebedev commented 1 year ago

With this PR I removed almost all conversion warnings and some other type of warnings. Where it was appropriate I did cast or change the value type.

Here I added a special check for the case when floats or ints are converted to std::complex<T>.

As a side remark, please consider if it is possible to change Scalar concept and remove Colplex<T> from it.

jsallay commented 1 year ago

As a side remark, please consider if it is possible to change Scalar concept and remove Colplex<T> from it.

Historically, in GNU Radio, a Complex has been considered a scalar value because it is a fundamental type used for DSP. I understand the dissonance of calling it a scalar though. I would be open to other interpretations, but we would need to think it through. Feel free to open an issue and explain how you think it would be best to organize.