VOLK profiling runs every time anything depending on gnuradio is built?

gnuradio / pybombs

PyBOMBS (Python Build Overlay Managed Bundle System) is the GNU Radio install management system for resolving dependencies and pulling in out-of-tree projects.

https://gnuradio.org

GNU General Public License v3.0

418 stars 190 forks source link

VOLK profiling runs every time anything depending on gnuradio is built? #120

Closed uwehermann closed 10 years ago

uwehermann commented 10 years ago

E.g. when running ./pybombs install pocsag-mrt (gnuradio has been built already beforehand):

packages to install: ['gnuradio', 'gr-as', 'gr-extras', 'pocsag-mrt']
install called (gnuradio)
install type priority: ['src']
install src called (gnuradio)
satisfy(gcc)
state = installed
installation ok via: src
Run VOLK Profile to choose fastest kernels[Y]/N? 
Submit anonymous VOLK performance statistics to stats.gnuradio.org? Y/[N]? 
please wait ... running volk profile, this will take several minutes... 
shellexec_long: volk_profile

I think running the profiling stuff should only happen automatically once (or not at all, and letting the user run it manually).

osh commented 10 years ago

hrmmm this is suppsoed to only run when gnuradio is built - not dependencies ....

uwehermann commented 10 years ago

I tried a fresh clone, and "src,deb" config. Building gnuradio for the first time runs the profiling, then another "./pybombs install gnuradio" and the profiling is run again (but gnuradio is correctly not rebuilt):

satisfy(git)
cmake dep [['wget']]
satisfy(cmake)
packages to install: ['uhd', 'gnuradio']
install called (uhd)
install type priority: ['src']
install src called (uhd)
satisfy(gcc)
state = installed
installation ok via: src
install called (gnuradio)
install type priority: ['src']
install src called (gnuradio)
satisfy(gcc)
state = installed
installation ok via: src
Run VOLK Profile to choose fastest kernels[Y]/N? 
Submit anonymous VOLK performance statistics to stats.gnuradio.org? Y/[N]? 
please wait ... running volk profile, this will take several minutes...

ckuethe commented 10 years ago

This is maybe because gnuradio is forcebuild? Maybe the profiling should check to see if gnuradio is already installed and not re-run the profiler?

osh commented 10 years ago

the latest patch may have addressed this, can you confirm it still is a problem in 1.0rc2?

osh commented 10 years ago

resolved

uwehermann commented 10 years ago

Seems to work fine now, thanks!