pybombs does not check for sudo

gnuradio / pybombs

PyBOMBS (Python Build Overlay Managed Bundle System) is the GNU Radio install management system for resolving dependencies and pulling in out-of-tree projects.

https://gnuradio.org

GNU General Public License v3.0

415 stars 189 forks source link

pybombs does not check for sudo #364

Open osh opened 8 years ago

osh commented 8 years ago

it is assumed to be installed, no check is provided lack of sudo results in an unhappy execution failed error with no good explanation as to what failed

when installing on a minimal ubuntu docker this becomes an issue quickly

mark3982 commented 8 years ago

Even with code to not use sudo if it does not exist. Does there still need to be a message generated (seems like a good idea) and what type of message is best?

mbr0wn commented 8 years ago

This is not quite a fix, but I've made the sudo thing a config option. You can now do (in ~/.pybombs/config.yml):

config:
  elevate_pre_args: [,]

and it will not use sudo.

E3V3A commented 7 years ago

I suggest also using a shell wrapper to pybombs to check for the sudo binary and current id.

mbr0wn commented 7 years ago

shell wrappers have the disadvantage of being non-portable.

mbr0wn commented 7 years ago

We have a couple of things in place now:

The autoconfig subcommand
The elevate_pre_args config option

I'm considering closing this issue. However, there are still some good ideas:

A check when not to elevate (also, a check when to elevate, see #304, but that's a separate issue).
A better checking of the elevate_pre_args value and better error output on failure.