gnuradio / pybombs

PyBOMBS (Python Build Overlay Managed Bundle System) is the GNU Radio install management system for resolving dependencies and pulling in out-of-tree projects.
https://gnuradio.org
GNU General Public License v3.0
414 stars 189 forks source link

Fix broken CI #576

Closed argilo closed 4 years ago

argilo commented 4 years ago

Travis CI began failing in 4cbdab04741e0735f0db697fd9a79a3ee1c0089e due to the following pylint error:

************* Module pybombs.config_file
E: 62,19: Unexpected keyword argument 'default_flow_style' in method call (unexpected-keyword-arg)

It seems pylint is confused because AbstractYaml.__init__ may leave _dump uninitialized. In any case, 4cbdab04741e0735f0db697fd9a79a3ee1c0089e made it impossible to reach the problematic else clause in AbstractYaml.dump, so we can simply remove the whole if statement.

I also noticed that ruamel version check was broken; it requires the minor version number to be at least 15, and so it would incorrectly reject things like versions 1.0 through 1.14 (if they were to appear in the future). I simplified the check to compare against the tuple (0, 15), which should correctly compare version numbers.