search

gnuradio / volk

The Vector Optimized Library of Kernels
http://libvolk.org
GNU Lesser General Public License v3.0
548 stars 202 forks source link

reserved identifier violation #194

Open elfring opened 6 years ago

elfring commented 6 years ago

I would like to point out that an identifier like “__VOLK_ASM” does eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

jdemel commented 4 years ago

I assume C++ and C naming conventions are aligned on this one. According to the naming convention page you linked, we should drop the leading __. We need to discuss why leading underscores were introduced in the first place. Also we need to discuss if it is save to remove them and if we want to remove them.

michaelld commented 4 years ago

Fascinating. I had no idea there were so many rules for naming conventions in C++. Crazy!

I have no objections to renaming any macro / identifier / function / variable, so long as the code still builds on a variety of OSs and using multiple different compilers and different compiler versions. We want to avoid using, and especially installing headers that have in them, a macro / identifier / function / variable that conflicts with other projects or the host OS.

That said, we seem to be OK right now with no conflicting macro / identifier / function / variable in builds or the installed headers. Hence, if someone else wants to tackle this, please do so. Otherwise, let's keep the issue around to remind us sometime down the road that this is a desirable change & we'll hopefully find time to do something about it then in the future.