gnuradio / volk

The Vector Optimized Library of Kernels
http://libvolk.org
GNU Lesser General Public License v3.0
557 stars 202 forks source link

Remove broken volk_16i_max_star_16i_neon protokernel #692

Closed argilo closed 12 months ago

argilo commented 1 year ago

A compiler warning points out that the vst1q_s16 call on line 142 results in a stack buffer overrun because candidate is not long enough to hold the result, which is an array of shorts. I verified with ASAN that a buffer overrun does in fact occur.

Since the volk_16i_max_star_16i kernel is deprecated, we may as well just remove this broken protokernel.