search

gnuradio / volk

The Vector Optimized Library of Kernels
http://libvolk.org
GNU Lesser General Public License v3.0
557 stars 202 forks source link

release script should switch to bash syntax completely #748

Closed jdemel closed 9 months ago

jdemel commented 10 months ago

The release script should always run in ZSH. However:

https://github.com/gnuradio/volk/commit/5b23afd72c30a9d6b0c82bfca6ddf0ce1f36e9e7

i.e. it runs in bash at the moment and produced a borked release.

argilo commented 10 months ago

My suggestion would be to change line 9 to set -e and then fix any errors that come up when running the script.

jdemel commented 10 months ago

My suggestion would be to change line 9 to set -e and then fix any errors that come up when running the script.

Actually, I prefer that too.

ZeroChaos- commented 10 months ago

I tried to give this a quick pass since this is something I'm decent at.

https://github.com/gnuradio/volk/pull/751