search

gnuradio / volk

The Vector Optimized Library of Kernels
http://libvolk.org
GNU Lesser General Public License v3.0
557 stars 202 forks source link

Release script improvements #751

Closed ZeroChaos- closed 9 months ago

ZeroChaos- commented 10 months ago

mostly shellcheck shellcheck but also a bit from me Closes: https://github.com/gnuradio/volk/issues/748

argilo commented 10 months ago

At a glance, the changes look good to me.

Could you add a signoff (git commit --amend -s) and push so that the DCO passes?

ZeroChaos- commented 10 months ago

this needs a little testing, don't merge yet please

ZeroChaos- commented 10 months ago

tested and safe to merge from my side.

ZeroChaos- commented 10 months ago

okay, my changes seem sane and are tested but I can't make the DCO check happy. Can someone please point out my failure so I can fix it right?

ZeroChaos- commented 10 months ago

it requires my gentoo email because I signed with that key maybe?

jdemel commented 10 months ago

The DCO check is happy now. That's great.

marcusmueller commented 10 months ago

Doesn't work for me:

ls: cannot access '/tmp/tmp.27l7Gm7mBG/volk-3.1.1-sub*.tar': No such file or directory
ZeroChaos- commented 10 months ago

Doesn't work for me:

ls: cannot access '/tmp/tmp.27l7Gm7mBG/volk-3.1.1-sub*.tar': No such file or directory

if possible, please grab the whole output from sh -x ./scripts/tools/release.sh and paste it here. I can make some guesses but seeing it all may help.

ZeroChaos- commented 10 months ago

I pushed a cleaner version of that, please test the latest rev and provide the requested output if it fails.

marcusmueller commented 10 months ago

oops, this was unintended :D

jdemel commented 9 months ago

Thanks everyone for testing and the updates!