Closed argilo closed 9 months ago
Rebased.
@argilo Thanks! I really appreciate your work here. Before I merge this, how are the test run? We had a lot of issues with this kernel in past. I'd like to make sure, we don't screw this kernel up again.
CI should do a decent job of testing the kernel now, since it verifies that all the protokernels produce identical bit streams when given noise as input. One thing that CI doesn't yet do is test with different vector lengths, which I did like so:
for v in {0..1024}; do apps/volk_profile -n -R k7_r2 -v $v -i 10 | grep fail; done
I ran that test on x86-64, ARM-64, and ARM-32.
Great. Merging.
Here I've continued cleaning up the convolutional decoder.
Since #755 is not merged yet, I've included it here, and will rebase the PR once it's merged.In two
additionalcommits I've made the following changes:With these changes, the tests still pass. I also verified (on x86 and ARM) that various vector lengths still work: