search

gnustavo / Git-Hooks

Framework for implementing Git (and Gerrit) hooks
http://search.cpan.org/dist/Git-Hooks/
41 stars 17 forks source link

Regression: pushing a new branch should not trigger checking past commits #31

Closed boudekerk closed 7 years ago

boudekerk commented 7 years ago

With recent versions we're seeing the is the same behaviour as reported earlier in https://github.com/gnustavo/Git-Hooks/issues/24. This was fixed in 1.12.2, but appears again as of 1.13.1. As a workaround we've reverted back to 1.13.0. The reproduction path from the issue above can be used.

boudekerk commented 7 years ago

Updated reproduction path:

HOOK=/data/git/bin/githooks.pl
CWD=$(pwd)
git init git-hooks-issue-31-remote
cd git-hooks-issue-31-remote
git checkout -b new-branch
cd ..
git clone file://${CWD}/git-hooks-issue-31-remote git-hooks-issue-31-local
cd git-hooks-issue-31-local
echo ${RANDOM} > README; git add README; git commit -m"Testing" README
git push
echo ${RANDOM} > README; git commit -m"Testing" README
git push
git checkout -b test-branch
ln -sf ${HOOK} ${CWD}/git-hooks-issue-31-remote/.git/hooks/pre-receive
git push -u origin test-branch
gnustavo commented 7 years ago

Hi, @boudekerk . You're right. Thanks for the report.

I think I fixed it in 7e28924 but I'd like to ask you to validade my change before I can make a new release. Can you give it a try?

boudekerk commented 7 years ago

Hi @gnustavo,

your fix indeed makes things work for us as expected. We don't have any post-(receive|update) hooks, so I didn't test whether those also still work.

Kind regards, Bartosz

boudekerk commented 7 years ago

Hi @gnustavo,

do you think you'll be able to create another release containing this fix?

Kind regards, Bartosz

gnustavo commented 7 years ago

Hi @boudekerk ,

I'm sorry for the delay. I just released v1.15.0 which should appear shortly on CPAN.