search

gnustavo / Git-Hooks

Framework for implementing Git (and Gerrit) hooks
http://search.cpan.org/dist/Git-Hooks/
41 stars 17 forks source link

Behavior change in ref_update hook #55

Closed mikkoi closed 5 years ago

mikkoi commented 5 years ago

I am not a Gerrit user. Just want to bring this to your attention: https://www.gerritcodereview.com/2.14.html#Behavior-change-in-ref_update-hook

gnustavo commented 5 years ago

Thanks, Mikko, I didn't know about that yet. I'll try to make the necessary accomodations soon.

Em seg, 1 de out de 2018 às 05:21, Mikko Koivunalho < notifications@github.com> escreveu:

I am not a Gerrit user. Just want to bring this to your attention:

https://www.gerritcodereview.com/2.14.html#Behavior-change-in-ref_update-hook

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gnustavo/Git-Hooks/issues/55, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG9SNFW8Cn7tLqSaSvNvgfGcyj6pgXcks5ugdCSgaJpZM4XBldm .

-- Gustavo.

gnustavo commented 5 years ago

I read more about the change. It seems to me that Git::Hooks still supports the ref-update hook as it is. But since the hook is not invoked anymore on commits received for review, or on submit of changes, it would be nice to also support the new hooks commit-received and submit. I marked this issue as an enhancement to signify this.

I'm using Gerrit 2.15.2 at work but I haven't noticed the change because I don't use the ref-update hook. We only use the patchset-created hook there. ;)

I'll try to implement this soon.

gnustavo commented 5 years ago

Hi, Mikko. I just released Git::Hooks v2.10.0 which now supports the two new Gerrit synchronous hooks.