Add support for proxy attribute passed via the rest client config hash

gnustavo / JIRA-REST

Thin wrapper around Jira's REST API

17 stars 18 forks source link

Add support for proxy attribute passed via the rest client config hash #2

Closed foic closed 9 years ago

foic commented 9 years ago

Rest::Client doesn't support providing a proxy in its config hash so a little extra work is needed to support passing this through.

Happy to move the proxy specification to be a top level argument to JIRA::REST::new() but this seemed the easiest way without changing the current interface.

gnustavo commented 9 years ago

Thank you, Andrew. This is a good idea.

I've made small changes to your commit and pushed it as 4d82883. Can you review it?

foic commented 9 years ago

Hi Gustavo,

Changes look great, thanks for accepting!

On 8 May 2015 at 04:44, Gustavo Chaves notifications@github.com wrote:

Thank you, Andrew. This is a good idea.

I've made small changes to your commit and pushed it as 4d82883 https://github.com/gnustavo/JIRA-REST/commit/4d828831dbc4dfe3d1303203b195d4d0031f0f9f. Can you review it?

— Reply to this email directly or view it on GitHub https://github.com/gnustavo/JIRA-REST/pull/2#issuecomment-99973853.

gnustavo commented 9 years ago

Thanks. I've just released version 0.011 which includes your contribution.